code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Don't mask TwythonStreamer exceptions

Browse source 
Exceptions in handlers or on_success which subclass ValueError would
previously be caught and reported as a JSON decoding problem, and
on_error() would be called (with status_code=200).
This commit is contained in:
Remi Rampin 2013-10-09 14:39:45 -04:00
parent 28b6d68b3b
commit 9bf83fd933
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
twython/streaming/api.py
View file

@ -139,14 +139,15 @@ class TwythonStreamer(object):
if is_py3:
line = line.decode('utf-8')
data = json.loads(line)
except ValueError: # pragma: no cover
self.on_error(response.status_code, 'Unable to decode response, not valid JSON.')
else:
if self.on_success(data): # pragma: no cover
for message_type in self.handlers:
if message_type in data:
handler = getattr(self, 'on_' + message_type, None)
if handler and callable(handler) and not handler(data.get(message_type)):
break
except ValueError: # pragma: no cover
self.on_error(response.status_code, 'Unable to decode response, not valid JSON.')
response.close()