code/twython
1
0
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Fix html_for_tweet()s handling of media URLs

Browse source 
We were trying to link to each media item using its
`url`/`expanded_url`. But there is only one of these, shared across
all of a tweet's media items. So attempting to put it in several times,
in the same location, was a bit of a mess!

So it now only puts the `url`/`expanded_url` in once, no matter
how many media items there are.
This commit is contained in:
Phil Gyford 2017-10-07 18:38:20 +01:00
parent 1511ee7b4d
commit a27efd9da8
4 changed files with 173 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

9
tests/test_html_for_tweet.py
View file

@ -5,6 +5,7 @@ from .config import (
test_tweet_object, test_tweet_html, test_tweet_symbols_object,
test_tweet_compat_object, test_tweet_extended_object,
test_tweet_extended_html, test_tweet_identical_urls, test_tweet_reply,
test_tweet_media,
unittest
)
@ -72,3 +73,11 @@ class TestHtmlForTweetTestCase(unittest.TestCase):
tweet_text = self.api.html_for_tweet(test_tweet_extended_object)
# full tweet rendered with suffix
self.assertEqual(test_tweet_extended_html, tweet_text)
def test_media(self):
tweet_text = self.api.html_for_tweet(test_tweet_media)
self.assertEqual(
"""I made some D3.js charts showing the years covered by books in a series compared to their publishing dates <a href="https://t.co/2yUmmn3TOc" class="twython-url">gyford.com/phil/writing/2…</a> <a href="https://t.co/OwNc6uJklg" class="twython-media">pic.twitter.com/OwNc6uJklg</a>""",
tweet_text)