Fixed broken params kwargs which was breaking updateStatusWithMedia #101

Merged
mgrouchy merged 1 commit from fix-updatestatuswithmedia-params into master 2012-06-29 08:38:22 -07:00
mgrouchy commented 2012-06-27 07:02:19 -07:00 (Migrated from github.com)
  • params are passed as **kwargs everywhere else, so updated
    _media_update to be consistent with that.
  • updated to updateProfileBackgroundImage to fall in line with
    _media_update changes.

Symptom of the problem is that updateStatusWithMedia was throwing:

TypeError: "_media_update() got an unexpected keyword argument 'status'" 

will also break for any other keyword argument as written.

With these rather small changes changes, all the media uploading calls should now work(most importantly the status updates).

- params are passed as **kwargs everywhere else, so updated _media_update to be consistent with that. - updated to updateProfileBackgroundImage to fall in line with _media_update changes. Symptom of the problem is that updateStatusWithMedia was throwing: ``` python TypeError: "_media_update() got an unexpected keyword argument 'status'" ``` will also break for any other keyword argument as written. With these rather small changes changes, all the media uploading calls should now work(most importantly the status updates).
michaelhelmick commented 2012-06-27 08:14:02 -07:00 (Migrated from github.com)

Good catch! Danke! 👍

Good catch! Danke! :thumbsup:
mgrouchy commented 2012-06-29 07:50:51 -07:00 (Migrated from github.com)

@ryanmcgrath any update on this getting included in a bug-fix release? I'd love to not have to use my patched copy/

@ryanmcgrath any update on this getting included in a bug-fix release? I'd love to not have to use my patched copy/
ryanmcgrath commented 2012-06-29 08:38:39 -07:00 (Migrated from github.com)

Merged, will push a point release shortly. Thanks!

Merged, will push a point release shortly. Thanks!
mgrouchy commented 2012-06-29 08:42:03 -07:00 (Migrated from github.com)

Awesome, thanks Ryan!

Awesome, thanks Ryan!
ryanmcgrath commented 2012-06-29 08:44:23 -07:00 (Migrated from github.com)

Always a pleasure when I see patches, it's just easy for them to get lost in the flow of everything. Thanks for keeping me honest!

Always a pleasure when I see patches, it's just easy for them to get lost in the flow of everything. Thanks for keeping me honest!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#101
No description provided.