Comments correction for get_lastfunction_header() #180

Merged

atrociousgrmblr merged 1 commit from master into master

2013-04-15 13:45:39 -07:00

atrociousgrmblr commented

2013-04-13 20:24:46 -07:00

(Migrated from github.com)

Headers have changed between 1.0 and 1.1. A - is now needed between rate and limit (see Rate limiting). I tried without and it doesn't work (return the whole header).

Headers have changed between 1.0 and 1.1. A `-` is now needed between `rate` and `limit` (see [Rate limiting](https://dev.twitter.com/docs/rate-limiting/1.1)). I tried without and it doesn't work (return the whole header).

michaelhelmick commented

2013-04-13 21:23:21 -07:00

(Migrated from github.com)

Thanks! I'll have a look at this Monday! :)

Sent from my iPhone

On Apr 13, 2013, at 11:24 PM, Adrien Tronche notifications@github.com wrote:

Headers have changed between 1.0 and 1.1. A - is now needed between rate and limit (see Rate limiting). I tried without and it doesn't work (return the whole header).

You can merge this Pull Request by running

git pull https://github.com/namimi/twython master
Or view, comment on, or merge it at:

https://github.com/ryanmcgrath/twython/pull/180

Commit Summary

Small correction in comments
File Changes

M twython/twython.py (8)
Patch Links:

https://github.com/ryanmcgrath/twython/pull/180.patch
https://github.com/ryanmcgrath/twython/pull/180.diff

Thanks! I'll have a look at this Monday! :) Sent from my iPhone On Apr 13, 2013, at 11:24 PM, Adrien Tronche notifications@github.com wrote: > Headers have changed between 1.0 and 1.1. A - is now needed between rate and limit (see Rate limiting). I tried without and it doesn't work (return the whole header). > > You can merge this Pull Request by running > > git pull https://github.com/namimi/twython master > Or view, comment on, or merge it at: > > https://github.com/ryanmcgrath/twython/pull/180 > > Commit Summary > > Small correction in comments > File Changes > > M twython/twython.py (8) > Patch Links: > > https://github.com/ryanmcgrath/twython/pull/180.patch > https://github.com/ryanmcgrath/twython/pull/180.diff

michaelhelmick commented

2013-04-15 12:12:59 -07:00

(Migrated from github.com)

@namimi Think we should capitalize the headers to fetch in the comments as well?

On the Rate Limiting page you linked, the headers look like this

X-Rate-Limit-Limit: the rate limit ceiling for that given request
X-Rate-Limit-Remaining: the number of requests left for the 15 minute window
X-Rate-Limit-Reset: the remaining window before the rate limit resets in UTC epoch seconds

Not x-rate-limit-limit, make sense? 🍰

@namimi Think we should capitalize the headers to fetch in the comments as well? On the Rate Limiting page you linked, the headers look like this ``` X-Rate-Limit-Limit: the rate limit ceiling for that given request X-Rate-Limit-Remaining: the number of requests left for the 15 minute window X-Rate-Limit-Reset: the remaining window before the rate limit resets in UTC epoch seconds ``` Not `x-rate-limit-limit`, make sense? :cake:

atrociousgrmblr commented

2013-04-15 13:44:53 -07:00

(Migrated from github.com)

@michaelhelmick I just checked: both work.

michaelhelmick commented

2013-04-15 13:45:33 -07:00

(Migrated from github.com)

Thank you, thank you! I'll merge this in! Should be a version bump out sometime this week! :)