code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Tests #196

Merged
michaelhelmick merged 6 commits from tests into master 2013-05-15 14:57:44 -07:00
Conversation 1 Commits 6 Files changed 3 +456
michaelhelmick commented 2013-05-14 18:53:31 -07:00 (Migrated from github.com)
Copy link

Fixes #169

Fixes #169
michaelhelmick commented 2013-05-15 14:57:24 -07:00 (Migrated from github.com)
Copy link

Okay, I'm going to merge this even though Travis fails. It succeded on 2.6 and 2.7 on Travis but failed on 3.3. But locally on 3.3, it succeed.

And then after my coverage commit, it didn't have secure vars (but had them on a76b93e491) >_>

Then I read this:

Please note that secure env variables are not available for pull requests. This is done due to the security risk of exposing such information in submitted code. Everyone can submit a pull request and if an unencrypted variable is available there, it could be easily displayed.

So I don't get why it would work once, but not again. but let's give this a shot on master and fix from there.

Okay, I'm going to merge this even though Travis fails. It succeded on 2.6 and 2.7 on Travis but failed on 3.3. But locally on 3.3, it succeed. And then after my coverage commit, it didn't have secure vars (but had them on https://github.com/ryanmcgrath/twython/commit/a76b93e49107d987bb7633a7374909be2a27ccf5) >_> Then I read this: > Please note that secure env variables are not available for pull requests. This is done due to the security risk of exposing such information in submitted code. Everyone can submit a pull request and if an unencrypted variable is available there, it could be easily displayed. So I don't get why it would work once, but not again. but let's give this a shot on `master` and fix from there.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#196
No description provided.
Delete branch "tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?