Fixed the for loop key and how to access the user name.

rubenvarela commented

2013-05-26 09:58:19 -07:00

(Migrated from github.com)

The key used in the for array (['results']) doesn't exist. It had to be changed to ['statuses'].

Also the way example code tried to access the username was wrong. Changed it too.

The key used in the for array (['results']) doesn't exist. It had to be changed to ['statuses']. Also the way example code tried to access the username was wrong. Changed it too.

michaelhelmick commented

2013-05-26 10:23:03 -07:00

(Migrated from github.com)

Ill accept the example fix but in the dev branch there is already a fix for the search_gen function. It's actually an issue I forgot to close. Thanks for using the library and contributing though :) if Ryan can't get to it today I'll merge this in sometime tomorrow and add you to the contributors :)

Sent from my iPhone

On May 26, 2013, at 12:58 PM, rubenvarela notifications@github.com wrote:

The key used in the for array (['results']) doesn't exist. It had to be changed to ['statuses'].

Also the way example code tried to access the username was wrong. Changed it too.

You can merge this Pull Request by running

git pull https://github.com/rubenvarela/twython fix-search_results.py
Or view, comment on, or merge it at:

https://github.com/ryanmcgrath/twython/pull/201

Commit Summary

Fixed the for loop key and how to access the user name.
File Changes

M examples/search_results.py (4)
Patch Links:

https://github.com/ryanmcgrath/twython/pull/201.patch
https://github.com/ryanmcgrath/twython/pull/201.diff

Ill accept the example fix but in the dev branch there is already a fix for the search_gen function. It's actually an issue I forgot to close. Thanks for using the library and contributing though :) if Ryan can't get to it today I'll merge this in sometime tomorrow and add you to the contributors :) Sent from my iPhone On May 26, 2013, at 12:58 PM, rubenvarela notifications@github.com wrote: > The key used in the for array (['results']) doesn't exist. It had to be changed to ['statuses']. > > Also the way example code tried to access the username was wrong. Changed it too. > > You can merge this Pull Request by running > > git pull https://github.com/rubenvarela/twython fix-search_results.py > Or view, comment on, or merge it at: > > https://github.com/ryanmcgrath/twython/pull/201 > > Commit Summary > > Fixed the for loop key and how to access the user name. > File Changes > > M examples/search_results.py (4) > Patch Links: > > https://github.com/ryanmcgrath/twython/pull/201.patch > https://github.com/ryanmcgrath/twython/pull/201.diff

rubenvarela commented

2013-05-28 06:51:45 -07:00

(Migrated from github.com)

Im sorry, I didn't see the dev branch.

I simply cloned the repo, tried the example, didn't work, created a branch, fixed it and decided to commit it. afterwards I continued working.

I'll check out the dev branch before any other commits. Thanks!

Im sorry, I didn't see the dev branch. I simply cloned the repo, tried the example, didn't work, created a branch, fixed it and decided to commit it. afterwards I continued working. I'll check out the dev branch before any other commits. Thanks!

Rows
Columns

Fixed the for loop key and how to access the user name. #201