code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

client_args to modify the request #227

Merged
michaelhelmick merged 1 commit from stream-client-args into master 2013-06-25 08:59:06 -07:00
Conversation 4 Commits 1 Files changed 1 +32 -10
michaelhelmick commented 2013-06-21 15:42:23 -07:00 (Migrated from github.com)
Copy link

Fixes #222

@extesy, is this what you had in mind? I removed headers from the __init__ BUT I kept timeout (even thought it should be passed through client_args, I feel like it's a big enough part of a streaming experience to stay in the init.

@ryanmcgrath Your thoughts on me keeping timeout in the __init__? Or should I remove timeout from the __init__ and just go for consistency?

Fixes #222 @extesy, is this what you had in mind? I removed `headers` from the `__init__` BUT I kept `timeout` (even thought it should be passed through `client_args`, I feel like it's a big enough part of a streaming experience to stay in the init. @ryanmcgrath Your thoughts on me keeping `timeout` in the `__init__`? Or should I remove `timeout` from the `__init__` and just go for consistency?
coveralls commented 2013-06-21 15:45:04 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage decreased (-0%) when pulling 26ef7b47bf on stream-client-args into e4098156f4 on master.

[![Coverage Status](https://coveralls.io/builds/83785/badge)](https://coveralls.io/builds/83785) Coverage decreased (-0%) when pulling **26ef7b47bf041c4ec0aec7a44f7f7ff3c923e4dc on stream-client-args** into **e4098156f41b7cde5267718c5efa730facf72e62 on master**.
ryanmcgrath commented 2013-06-21 16:50:29 -07:00 (Migrated from github.com)
Copy link

I think timeout makes sense in the __init__, at least from a user perspective. If I were coming to this new I wouldn't expect it to be anywhere else.

I think `timeout` makes sense in the `__init__`, at least from a user perspective. If I were coming to this new I wouldn't expect it to be anywhere else.
extesy commented 2013-06-23 22:43:40 -07:00 (Migrated from github.com)
Copy link

Yep, that's exactly what I had in mind. Thanks for fixing this, Michael!

Yep, that's exactly what I had in mind. Thanks for fixing this, Michael!
michaelhelmick commented 2013-06-24 08:30:46 -07:00 (Migrated from github.com)
Copy link

@extesy Cool beans! Look out for a new release of Twython tonight or tomorrow! :)

@extesy Cool beans! Look out for a new release of Twython tonight or tomorrow! :)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#227
No description provided.
Delete branch "stream-client-args"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?