HTML for tweet #233
No reviewers
Labels
No labels
Bug
Enhancement
Feature Suggestion
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: code/twython#233
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "html-for-tweet"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
fixes #224
@trevoriancox does this look good to you?
Also, @ryanmcgrath In the files changed, you'll see the function. I am returning specific classes
class=twython-hashtag, etc.. in case they want to style it different or do something with javascript to it. Should I leave it like this or should I make use of themention_html,hashtag_htmlanduser_htmlas variables I have and let them pass their own string formatted custom html or is that to complicated? My vote is for the first and just add the twython custom classes to the anchor tagsExample:
Which produces:
Changes Unknown when pulling
173adee4a6on html-for-tweet into * on master*.Changes Unknown when pulling
173adee4a6on html-for-tweet into * on master*.Yo, I'ma let you finish, but this is sickness.
On Tue, Jun 25, 2013 at 10:06 PM, Coveralls notifications@github.comwrote:
Skype: ryanmcgrathr
Twitter: http://twitter.com/ryanmcgrath/
Web: http://venodesigns.net/
GitHub: http://github.com/ryanmcgrath/
Not sure if you saw my mention in the PR but
Do the first and let 'em regex or DOM Manip.
On Wednesday, June 26, 2013, Mike Helmick wrote:
Skype: ryanmcgrathr
Twitter: http://twitter.com/ryanmcgrath/
Web: http://venodesigns.net/
GitHub: http://github.com/ryanmcgrath/
Works for me! Great to see this coming together!
Changes Unknown when pulling
3c637ddc7don html-for-tweet into * on master*.