code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

The cursor wasn't working to get user tweets and searches. It was always returning the same results #332

Closed
s0ckz wants to merge 2 commits from master into master
pull from: master
merge into: code:master
Conversation 3 Commits 2 Files changed 1 +15 -14
s0ckz commented 2014-06-02 16:03:09 -07:00 (Migrated from github.com)
Copy link

I also added a sleep property to avoid problems with Twitter rates.

I also added a sleep property to avoid problems with Twitter rates.
michaelhelmick commented 2014-06-03 08:49:30 -07:00 (Migrated from github.com)
Copy link

I'm fine with the fixing the loop, but I think adding a time.sleep in code (that is used in production code for people who use this library) isn't the best solution. Rate-limiting should be handled by the application, and not by Twython. We raise an Exception and the developer can handle the rate limiting on their own (pausing a celery task, etc.) instead of forcing a time.sleep

I'm fine with the fixing the loop, but I think adding a `time.sleep` in code (that is used in production code for people who use this library) isn't the best solution. Rate-limiting should be handled by the application, and not by Twython. We raise an `Exception` and the developer can handle the rate limiting on their own (pausing a celery task, etc.) instead of forcing a `time.sleep`
s0ckz commented 2014-06-03 08:51:39 -07:00 (Migrated from github.com)
Copy link

I totally agree! The sleep part is more for my app purposes.
Em 03/06/2014 12:49, "Mike Helmick" notifications@github.com escreveu:

I'm fine with the fixing the loop, but I think adding a time.sleep in
code (that is used in production code for people who use this library)
isn't the best solution. Rate-limiting should be handled by the
application, and not by Twython. We raise an Exception and the developer
can handle the rate limiting on their own (pausing a celery task, etc.)
instead of forcing a time.sleep

—
Reply to this email directly or view it on GitHub
https://github.com/ryanmcgrath/twython/pull/332#issuecomment-44982409.

I totally agree! The sleep part is more for my app purposes. Em 03/06/2014 12:49, "Mike Helmick" notifications@github.com escreveu: > I'm fine with the fixing the loop, but I think adding a time.sleep in > code (that is used in production code for people who use this library) > isn't the best solution. Rate-limiting should be handled by the > application, and not by Twython. We raise an Exception and the developer > can handle the rate limiting on their own (pausing a celery task, etc.) > instead of forcing a time.sleep > > — > Reply to this email directly or view it on GitHub > https://github.com/ryanmcgrath/twython/pull/332#issuecomment-44982409.
chasrmartin commented 2014-06-18 08:21:16 -07:00 (Migrated from github.com)
Copy link

Hey, guys, I'm running into this too. Any idea when it'll be merged?

Hey, guys, I'm running into this too. Any idea when it'll be merged?

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#332
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?