code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Adding upload media endpoint #349

Merged
filipeximenes merged 1 commit from master into master 2014-10-28 13:48:42 -07:00
Conversation 5 Commits 1 Files changed 1 +10
filipeximenes commented 2014-10-23 08:04:19 -07:00 (Migrated from github.com)
Copy link

I started having some problems with update_with_media method and it looks like it's deprecated:
https://dev.twitter.com/rest/reference/post/statuses/update_with_media

The new method to update with media is described in here:
https://dev.twitter.com/rest/public/uploading-media-multiple-photos

This pull request adds upload_media method to twython so images can first be uploaded to twitter before they are attached to a update.
I also added to docstring an explanation on how to proceed after uploading the media.

I started having some problems with update_with_media method and it looks like it's deprecated: https://dev.twitter.com/rest/reference/post/statuses/update_with_media The new method to update with media is described in here: https://dev.twitter.com/rest/public/uploading-media-multiple-photos This pull request adds `upload_media` method to twython so images can first be uploaded to twitter before they are attached to a update. I also added to docstring an explanation on how to proceed after uploading the media.
coveralls commented 2014-10-23 08:10:29 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage decreased (-0.02%) when pulling 83379b42e6 on filipeximenes:master into 00ccafe0c9 on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/1374982/badge)](https://coveralls.io/builds/1374982) Coverage decreased (-0.02%) when pulling **83379b42e6ba5249265a26e23cd2345a521fb21b on filipeximenes:master** into **00ccafe0c938da57397d6393c1a575096d758f5b on ryanmcgrath:master**.
Menelion commented 2014-10-23 08:40:21 -07:00 (Migrated from github.com)
Copy link

A huge 👍 on adding this endpoint!

A huge :+1: on adding this endpoint!
michaelhelmick commented 2014-10-23 09:54:19 -07:00 (Migrated from github.com)
Copy link

I'll try and push a release by tomorrow!!

I'll try and push a release by tomorrow!!
filipeximenes commented 2014-10-23 09:58:00 -07:00 (Migrated from github.com)
Copy link

May be a good idea to add a deprecation warning or at least a note on the update_with_media docstring.

May be a good idea to add a deprecation warning or at least a note on the `update_with_media` docstring.
michaelhelmick commented 2014-10-28 13:48:37 -07:00 (Migrated from github.com)
Copy link

@filipeximenes Good idea.

Also, guys, I didn't forget about this! I have it on my to-dos; with the latest due date being Thursday. So, no matter what. Expect a release by Thursday!

@filipeximenes Good idea. Also, guys, I didn't forget about this! I have it on my to-dos; with the latest due date being Thursday. So, no matter what. Expect a release by Thursday!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#349
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?