Remove redundant checking for oauth_token & oauth_token_secret

derek-dchu commented

2014-11-18 22:21:01 -08:00

(Migrated from github.com)

Remove redundant checking for oauth_token & oauth_token_secret when using OAuth1 method from requests_oauthlib, because it is already handling None values for us.

coveralls commented

2014-11-18 22:22:30 -08:00

(Migrated from github.com)

Coverage increased (+0.02%) when pulling 8eb8c2dd55 on derek-dchu:master into 245873b92f on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/1495002/badge)](https://coveralls.io/builds/1495002) Coverage increased (+0.02%) when pulling **8eb8c2dd556bb0efed9cd8f0e77ccfa59e7c0d82 on derek-dchu:master** into **245873b92f1b14328d93615f13864023d2df423c on ryanmcgrath:master**.

michaelhelmick commented

2014-11-19 08:43:37 -08:00

(Migrated from github.com)

Have you tested obtaining authentication tokens? I think we did that logic because there was an issue with setting oauth_token and oauth_token_secret to None when calling OAuth1

Have you tested obtaining authentication tokens? I think we did that logic because there was an issue with setting `oauth_token` and `oauth_token_secret` to `None` when calling `OAuth1`

derek-dchu commented

2014-11-19 08:51:14 -08:00

(Migrated from github.com)

I successfully updated status from the first step that is authorizing my app by calling get_authentication_tokens() in which we don't have oauth_token, oauth_token_secret. It generated a callback as usual and everything work flawlessly after that.

Rows
Columns

Remove redundant checking for oauth_token & oauth_token_secret #357