code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Improve replacing of entities with links in html_for_tweet() #451

Merged
philgyford merged 2 commits from fix-447 into master 2017-08-23 06:49:14 -07:00
Conversation 4 Commits 2 Files changed 3 +92 -48
philgyford commented 2017-08-22 05:57:39 -07:00 (Migrated from github.com)
Copy link

I've re-written the parts of html_for_tweet() so that it handles
all the replacements of URLs, mentions, symbols and hashtags better.

Mainly to fix #447 but it should be a little more robust generally.

It also now handles a rare case where a tweet doesn't have
symbols in its entities.

I've re-written the parts of `html_for_tweet()` so that it handles all the replacements of URLs, mentions, symbols and hashtags better. Mainly to fix #447 but it should be a little more robust generally. It also now handles a rare case where a tweet doesn't have `symbols` in its `entities`.
coveralls commented 2017-08-22 05:59:53 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage increased (+1.2%) to 56.593% when pulling 6890802b2a on philgyford:fix-447 into 5a87fc7d84 on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/12937533/badge)](https://coveralls.io/builds/12937533) Coverage increased (+1.2%) to 56.593% when pulling **6890802b2ae528557fdb1a528b4efd17470b5702 on philgyford:fix-447** into **5a87fc7d842994c48d32da10dc817fb1a9af16d7 on ryanmcgrath:master**.
coveralls commented 2017-08-22 05:59:53 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage increased (+1.2%) to 56.593% when pulling 6890802b2a on philgyford:fix-447 into 5a87fc7d84 on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/12937533/badge)](https://coveralls.io/builds/12937533) Coverage increased (+1.2%) to 56.593% when pulling **6890802b2ae528557fdb1a528b4efd17470b5702 on philgyford:fix-447** into **5a87fc7d842994c48d32da10dc817fb1a9af16d7 on ryanmcgrath:master**.
coveralls commented 2017-08-22 05:59:53 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage increased (+1.2%) to 56.593% when pulling 6890802b2a on philgyford:fix-447 into 5a87fc7d84 on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/12937533/badge)](https://coveralls.io/builds/12937533) Coverage increased (+1.2%) to 56.593% when pulling **6890802b2ae528557fdb1a528b4efd17470b5702 on philgyford:fix-447** into **5a87fc7d842994c48d32da10dc817fb1a9af16d7 on ryanmcgrath:master**.
michaelhelmick commented 2017-08-23 06:49:11 -07:00 (Migrated from github.com)
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#451
No description provided.
Delete branch "fix-447"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?