code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Make html_for_tweet() link a replied-to username #456

Merged
philgyford merged 1 commit from fix-html-for-tweet into master 2017-10-04 06:00:45 -07:00
Conversation 2 Commits 1 Files changed 3 +13 -2
philgyford commented 2017-10-03 11:15:07 -07:00 (Migrated from github.com)
Copy link

If a tweet was a reply, then when html_for_tweet() tried to turn
the initial "@username" into a link, there was:

NameError: name 'sub_expr' is not defined

This is now fixed, with a test to ensure the "@username" becomes
a link.

I introduced this when refactoring html_for_tweet() a while ago, sorry.

If a tweet was a reply, then when `html_for_tweet()` tried to turn the initial "@username" into a link, there was: > NameError: name 'sub_expr' is not defined This is now fixed, with a test to ensure the "@username" becomes a link. I introduced this when refactoring `html_for_tweet()` a while ago, sorry.
coveralls commented 2017-10-03 11:31:29 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage increased (+0.2%) to 57.182% when pulling 0ee9b76b5c on philgyford:fix-html-for-tweet into 97f78fd89b on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/13550224/badge)](https://coveralls.io/builds/13550224) Coverage increased (+0.2%) to 57.182% when pulling **0ee9b76b5cb6fd86ce8b75287ca33579fd1d18b5 on philgyford:fix-html-for-tweet** into **97f78fd89b40e0b81e415f3407b15cb0fdef5677 on ryanmcgrath:master**.
michaelhelmick (Migrated from github.com) approved these changes 2017-10-04 06:00:31 -07:00
Sign in to join this conversation.
Reviewers
No reviewers
michaelhelmick
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#456
No description provided.
Delete branch "fix-html-for-tweet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?