Added create_metadata endpoint #460

2017-10-07T09:46:21-07:00

jmdaweb commented

2017-10-07 09:46:21 -07:00

(Migrated from github.com)

I have added the create_metadata endpoint for image descriptions. Now it should pass all tests. The following modifications have been made to api.py:

JSON exception will raise only if response content is not empty.
_transparent_params is only called if params is a dictionary

I have added the create_metadata endpoint for image descriptions. Now it should pass all tests. The following modifications have been made to api.py: * JSON exception will raise only if response content is not empty. * _transparent_params is only called if params is a dictionary

coveralls commented

2017-10-07 09:48:09 -07:00

(Migrated from github.com)

Coverage decreased (-0.02%) to 57.162% when pulling 6fc7b9e038 on jmdaweb:master into 12e6b34d1d on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/13616141/badge)](https://coveralls.io/builds/13616141) Coverage decreased (-0.02%) to 57.162% when pulling **6fc7b9e0386110eb05ed897d561004115407c508 on jmdaweb:master** into **12e6b34d1df5f292c6d867d2358d43d0e7c40142 on ryanmcgrath:master**.

michaelhelmick (Migrated from github.com) requested changes 2017-10-09 08:56:45 -07:00

michaelhelmick (Migrated from github.com) left a comment

Thanks for fixing up your code in this new pull request. Can you adjust your code to the changes in my review? Thanks!

twython/api.py

					
				@ -140,7 +140,11 @@ class Twython(EndpointsMixin, object):

				        params = params or {}

michaelhelmick (Migrated from github.com) commented

2017-10-09 08:56:10 -07:00

Can you make this if isinstance(params, dict)

Can you make this `if isinstance(params, dict)`

twython/api.py

					
				@ -192,15 +196,16 @@ class Twython(EndpointsMixin, object):

				                error_message,

michaelhelmick (Migrated from github.com) commented

2017-10-09 08:55:33 -07:00

Can you make this line:

if response.content != '' (spaces around operator and single quotes

Can you make this line: `if response.content != ''` (spaces around operator and single quotes

michaelhelmick (Migrated from github.com) commented

2017-10-09 08:55:55 -07:00

content = '' Space around operators and single quotes

`content = ''` Space around operators and single quotes

coveralls commented

2017-10-09 09:13:46 -07:00

(Migrated from github.com)

Coverage decreased (-0.02%) to 57.162% when pulling 2cb2ed4a31 on jmdaweb:master into 12e6b34d1d on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/13634097/badge)](https://coveralls.io/builds/13634097) Coverage decreased (-0.02%) to 57.162% when pulling **2cb2ed4a31826349ad81e39a5c035a7eed98c6b1 on jmdaweb:master** into **12e6b34d1df5f292c6d867d2358d43d0e7c40142 on ryanmcgrath:master**.

michaelhelmick commented

2017-10-09 13:26:15 -07:00

(Migrated from github.com)

Thanks!

Sign in to join this conversation.

No reviewers

michaelhelmick