TwythonError hides too many details from error message #482

New issue

Open

opened 2018-02-06 10:28:21 -08:00 by anentropic · 1 comment

anentropic commented

2018-02-06 10:28:21 -08:00

(Migrated from github.com)

errors are raised something like:

raise TwythonError(
    error_message,  # text of first error if there are multiple
    error_code=response.status_code,
)

In Twitter API docs the errors are assigned an error code

For example the rate limit for posting status updates will return http 403 with error code 88, but the TwythonError only gives us 403 (plus the message "Rate limit exceeded")

So we can match on the text of the error but we wonder if Twitter may localise the text or amend the description at some point.

It would be nice to have access to the error code in error_code, with the http response status code as a separate attribute. In fact it would be useful to have the whole error body to work with.

errors are raised something like: ```python raise TwythonError( error_message, # text of first error if there are multiple error_code=response.status_code, ) ``` In [Twitter API docs](https://developer.twitter.com/en/docs/basics/response-codes) the errors are assigned an error code For example the rate limit for posting status updates will return http `403` with error code `88`, but the `TwythonError` only gives us `403` (plus the message `"Rate limit exceeded"`) So we can match on the text of the error but we wonder if Twitter may localise the text or amend the description at some point. It would be nice to have access to the error code in `error_code`, with the http response status code as a separate attribute. In fact it would be useful to have the whole error body to work with.

michaelhelmick commented

2018-02-07 07:18:05 -08:00

(Migrated from github.com)

@anentropic that sounds wonderful. I'd be open to a PR that changes error_code to the Twitter error_code and a new status_code attribute on TwythonError

@anentropic that sounds wonderful. I'd be open to a PR that changes error_code to the Twitter error_code and a new status_code attribute on `TwythonError`

No labels

Bug

Enhancement

Feature Suggestion

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#482

No description provided.

Rows
Columns