Twython.callback_url does not exist #552

Open
opened 2023-08-23 16:03:30 -07:00 by jvanasco · 2 comments
jvanasco commented 2023-08-23 16:03:30 -07:00 (Migrated from github.com)

This error popped up while working on a project that subclasses this.

There is a backup function to invoke self.callback_url on the Twython class, however that attribute is never assigned or defined.

Looking at the history of the project, I think this was marked for deprecation in 2011 and removed in 2013, but this reference somehow remained.

0c40560428/twython/api.py (L359-L361)

This error popped up while working on a project that subclasses this. There is a backup function to invoke `self.callback_url` on the Twython class, however that attribute is never assigned or defined. Looking at the history of the project, I think this was marked for deprecation in 2011 and removed in 2013, but this reference somehow remained. https://github.com/ryanmcgrath/twython/blob/0c405604285364457f3c309969f11ba68163bd05/twython/api.py#L359-L361
ryanmcgrath commented 2023-08-24 00:27:41 -07:00 (Migrated from github.com)

Wow! Talk about ancient history. How were you triggering this - just a standard OAuth flow?

Wow! Talk about ancient history. How were you triggering this - just a standard OAuth flow?
jvanasco commented 2023-08-24 08:08:38 -07:00 (Migrated from github.com)

I have a project that integrates oauthlib into the Pyramid framework. I based the client class for the tests on Twython.

I was updating it with typing support, and one of the linters picked this up. I think mypy. I traced it back to Twython, then audited your code and the repo's history -- and found the tickets where a bunch of this stuff was reorganized.

I have a project that integrates oauthlib into the Pyramid framework. I based the client class for the tests on Twython. I was updating it with typing support, and one of the linters picked this up. I think mypy. I traced it back to Twython, then audited your code and the repo's history -- and found the tickets where a bunch of this stuff was reorganized.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#552
No description provided.