code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Implement requests #65

Merged
michaelhelmick merged 3 commits from implement_requests into master 2012-03-18 06:56:35 -07:00
Conversation 2 Commits 3 Files changed 3 +457 -423
michaelhelmick commented 2012-03-08 09:24:46 -08:00 (Migrated from github.com)
Copy link

Looks like it's all good to go! Feel free to test stuff. :)

Looks like it's all good to go! Feel free to test stuff. :)
ryanmcgrath commented 2012-03-12 15:24:54 -07:00 (Migrated from github.com)
Copy link

I like this, and am testing it as I get time (currently hopping around Europe). The only issue I have offhand is removing shortenURL - I know that there are people who use this still, and I'd rather not break their code for something somewhat needless.

We can either:

  • Stub it; just have it return the url passed and let Twitter handle the shortening...
  • Or just leave it as-is, as some people might have used this for legitimate shortening through is.gd
I like this, and am testing it as I get time (currently hopping around Europe). The only issue I have offhand is removing `shortenURL` - I know that there are people who use this still, and I'd rather not break their code for something somewhat needless. We can either: - Stub it; just have it return the url passed and let Twitter handle the shortening... - Or just leave it as-is, as some people might have used this for legitimate shortening through is.gd
michaelhelmick commented 2012-03-12 15:26:17 -07:00 (Migrated from github.com)
Copy link

As is, is fine. I just felt it was not needed because twitter does t.cos on everything.

Sent from my iPhone

On Mar 12, 2012, at 6:24 PM, Ryan McGrathreply@reply.github.com wrote:

I like this, and am testing it as I get time (currently hopping around Europe). The only issue I have offhand is removing shortenURL - I know that there are people who use this still, and I'd rather not break their code for something somewhat needless.

We can either:

  • Stub it; just have it return the url passed and let Twitter handle the shortening...
  • Or just leave it as-is, as some people might have used this for legitimate shortening through is.gd

Reply to this email directly or view it on GitHub:
https://github.com/ryanmcgrath/twython/pull/65#issuecomment-4463188

As is, is fine. I just felt it was not needed because twitter does t.cos on everything. Sent from my iPhone On Mar 12, 2012, at 6:24 PM, Ryan McGrathreply@reply.github.com wrote: > I like this, and am testing it as I get time (currently hopping around Europe). The only issue I have offhand is removing shortenURL - I know that there are people who use this still, and I'd rather not break their code for something somewhat needless. > > We can either: > - Stub it; just have it return the url passed and let Twitter handle the shortening... > - Or just leave it as-is, as some people might have used this for legitimate shortening through is.gd > > --- > > Reply to this email directly or view it on GitHub: > https://github.com/ryanmcgrath/twython/pull/65#issuecomment-4463188
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#65
No description provided.
Delete branch "implement_requests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?