code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

I fixed line 479 to properly URL encode the querystring (q parameter) fo... #83

Merged
Voulnet merged 1 commit from patch-2 into master 2012-04-19 15:28:21 -07:00
Conversation 1 Commits 1 Files changed 1 +1 -1
Voulnet commented 2012-04-13 19:34:29 -07:00 (Migrated from github.com)
Copy link

...r the search functionality. According to http://dev.twitter.com/doc/get/search, the q parameter should be URL encoded, but Twython.unicode2utf8 doesn't urlencode the query.

So I enclosed it in a urllib.quote_plus function call.

examples:

urllib.quote_plus(Twython.unicode2utf8('h ^&$'))
'h+%5E%26%24'
Twython.unicode2utf8('h ^&$')
'h ^&$'

...r the search functionality. According to http://dev.twitter.com/doc/get/search, the q parameter should be URL encoded, but Twython.unicode2utf8 doesn't urlencode the query. So I enclosed it in a urllib.quote_plus function call. examples: > > > urllib.quote_plus(Twython.unicode2utf8('h ^&$')) > > > 'h+%5E%26%24' > > > Twython.unicode2utf8('h ^&$') > > > 'h ^&$'
ryanmcgrath commented 2012-04-19 15:28:18 -07:00 (Migrated from github.com)
Copy link

Huh, this used to be taken care of, but could have been dropped in the switch to requests by mistake. Either way, looks alright to me, nice find! Merging...

Huh, this used to be taken care of, but could have been dropped in the switch to `requests` by mistake. Either way, looks alright to me, nice find! Merging...
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#83
No description provided.
Delete branch "patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?