Requests image posting #91

Merged

michaelhelmick merged 7 commits from requests_image_posting into master

2012-06-24 13:02:38 -07:00

michaelhelmick commented

2012-05-17 09:25:01 -07:00

(Migrated from github.com)

README.rst, kind of tried to clean up docs with more examples
No longer need oauth2 lib 👍
Removal of oauth2 lib, requests has fully taken over. :)
FIXED: Obtaining auth url with specified callback was broke..
wouldn't give you auth url if you specified a callback url
Updated requests to pass the headers that are passed in the init, so
User-Agent is once again Twython Python Twitter Library v2.1.0
👍 :)
Catching exception when Stream API doesn't return valid JSON to parse
Removed DELETE method. As of the Spring 2012 clean up, Twitter no
longer supports this method
Updated post internal func to take files as kwarg
params - params or {} only needs to be done in _request, just a
lot of redundant code on my part, sorry ;P
Removed bulkUserLookup, there is no need for this to be a special
case, anyone can pass a string of username or user ids and chances are
if they're reading the docs and using this library they'll understand
how to use lookupUser() in twitter_endpoints.py passing params
provided in the Twitter docs
Changed internal oauth_secret variable to be more consistent with
the keyword arg in the init oauth_token_secret
README.md vs README.markdown just look cleaner
Updating documentation to look clean, imo. :P
Set self.auth = None so that calls (like searching or getting a
profile avatar don't error out) Fixes #90

- README.rst, kind of tried to clean up docs with more examples - No longer need oauth2 lib :thumbsup: - Removal of oauth2 lib, `requests` has fully taken over. :) - FIXED: Obtaining auth url with specified callback was broke.. wouldn't give you auth url if you specified a callback url - Updated requests to pass the headers that are passed in the init, so User-Agent is once again `Twython Python Twitter Library v2.1.0` :thumbsup: :) - Catching exception when Stream API doesn't return valid JSON to parse - Removed `DELETE` method. As of the Spring 2012 clean up, Twitter no longer supports this method - Updated `post` internal func to take files as kwarg - `params - params or {}` only needs to be done in `_request`, just a lot of redundant code on my part, sorry ;P - Removed `bulkUserLookup`, there is no need for this to be a special case, anyone can pass a string of username or user ids and chances are if they're reading the docs and using this library they'll understand how to use `lookupUser()` in `twitter_endpoints.py` passing params provided in the Twitter docs - Changed internal `oauth_secret` variable to be more consistent with the keyword arg in the init `oauth_token_secret` - `README.md` vs `README.markdown` just look cleaner - Updating documentation to look clean, imo. :P - Set `self.auth` = None so that calls (like searching or getting a profile avatar don't error out) Fixes #90

michaelhelmick commented

2012-05-17 09:26:04 -07:00

(Migrated from github.com)

We need to wait for a new release (0.12.2 I believe it will be) of requests before we can merge this in

**We need to wait for a new release (0.12.2 I believe it will be) of `requests` before we can merge this in**

ryanmcgrath commented

2012-05-22 01:45:50 -07:00

(Migrated from github.com)

Hey,

Waiting for new release is fine; in the meantime, that auth fix is biting some people in the ass. Separate pull request?

Hey, Waiting for new release is fine; in the meantime, that auth fix is biting some people in the ass. Separate pull request?

michaelhelmick commented

2012-05-22 06:45:40 -07:00

(Migrated from github.com)

That's fine. I'll send a PR for it in an hour. Heading to the office

Sent from my iPhone

On May 22, 2012, at 4:45 AM, Ryan McGrathreply@reply.github.com wrote:

Hey,

Waiting for new release is fine; in the meantime, that auth fix is biting some people in the ass. Separate pull request?

Reply to this email directly or view it on GitHub:
https://github.com/ryanmcgrath/twython/pull/91#issuecomment-5842089

That's fine. I'll send a PR for it in an hour. Heading to the office Sent from my iPhone On May 22, 2012, at 4:45 AM, Ryan McGrathreply@reply.github.com wrote: > Hey, > > Waiting for new release is fine; in the meantime, that auth fix is biting some people in the ass. Separate pull request? > > --- > > Reply to this email directly or view it on GitHub: > https://github.com/ryanmcgrath/twython/pull/91#issuecomment-5842089

michaelhelmick commented

2012-05-30 07:36:14 -07:00

(Migrated from github.com)

@ryanmcgrath Hey, this should be all go to go :)

michaelhelmick commented

2012-05-30 07:38:56 -07:00

(Migrated from github.com)

You can close #80 and #90 with this merge too.