code/wrench-js
Archived
1
Fork 0
Code Issues 22 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Update lib/wrench.js #12

Merged
fishmongr merged 1 commit from patch-1 into master 2012-01-16 13:46:35 -08:00
Conversation 1 Commits 1 Files changed 1 +1 -1
fishmongr commented 2012-01-16 13:41:02 -08:00 (Migrated from github.com)
Copy link

For rmdirSyncRecurisve I believe:
var currFile = fs.statSync(path + "/" + files[i]);
should be
var currFile = fs.lstatSync(path + "/" + files[i]);

so any symbolic links will be evaluated as the link instead of the file it resolves to.
Currently a symbolic linked folder being deleted will receive an ENOTDIR, not a directory.

For rmdirSyncRecurisve I believe: var currFile = fs.statSync(path + "/" + files[i]); should be var currFile = fs.lstatSync(path + "/" + files[i]); so any symbolic links will be evaluated as the link instead of the file it resolves to. Currently a symbolic linked folder being deleted will receive an ENOTDIR, not a directory.
ryanmcgrath commented 2012-01-16 13:46:46 -08:00 (Migrated from github.com)
Copy link

Done. Many thanks, will push a point release!

Done. Many thanks, will push a point release!
This repository is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Request
No labels
Bug
Enhancement
Feature Request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/wrench-js#12
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?