code/wrench-js
Archived
1
Fork 0
Code Issues 22 Pull requests 7 Projects Releases Packages Wiki Activity Actions

readdirSyncRecursive returns file names on Linux, file paths on Windows #26

New issue
Closed
opened 2012-05-01 08:23:06 -07:00 by domenic · 2 comments
domenic commented 2012-05-01 08:23:06 -07:00 (Migrated from github.com)
Copy link

This caused some problems deploying from a Windows dev environment to a Linux production environment :-/.

This caused some problems deploying from a Windows dev environment to a Linux production environment :-/.
ryanmcgrath commented 2012-05-13 08:47:35 -07:00 (Migrated from github.com)
Copy link

Hmm... I don't have a VM to test on at the moment. Is this down to a platform difference in Node.js, by any chance? If so I feel like it's more of an upstream bug for them.

Hmm... I don't have a VM to test on at the moment. Is this down to a platform difference in Node.js, by any chance? If so I feel like it's more of an upstream bug for them.
domenic commented 2012-05-14 16:33:29 -07:00 (Migrated from github.com)
Copy link

Nah, just down to using manual string manipulation instead of the path module.

There are lots of other places in the code that do such string manipulation (e.g. concatenation with / instead of using path.join), but all the tests pass on Windows now, so it seems likely they don't matter.

Nah, just down to using manual string manipulation instead of the `path` module. There are lots of other places in the code that do such string manipulation (e.g. concatenation with `/` instead of using `path.join`), but all the tests pass on Windows now, so it seems likely they don't matter.
This repository is archived. You cannot comment on issues.
No Branch/Tag specified
Branches Tags
master
gh-pages
No results found.
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Request
No labels
Bug
Enhancement
Feature Request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/wrench-js#26
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?