code/wrench-js
Archived
1
0
Fork 0
Code Issues 22 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Consider graceful-fs #68

New issue
Open
opened 2013-11-25 13:44:53 -08:00 by silverwind · 6 comments
silverwind commented 2013-11-25 13:44:53 -08:00 (Migrated from github.com)
Copy link

Hey, I'm regulary running into issues with EACCES / ENOENT when recursively removing directories containing thousands of files with wrench.rmdirSyncRecursive on a Windows server.

Now I'm wondering if you would consider using graceful-fs, which is a drop-in replacement for node's fs module and seems to solve a lot of issues I had with locked files on Windows.

I can send a PR if you like.

Hey, I'm regulary running into issues with EACCES / ENOENT when recursively removing directories containing thousands of files with `wrench.rmdirSyncRecursive` on a Windows server. Now I'm wondering if you would consider using [graceful-fs](https://github.com/isaacs/node-graceful-fs), which is a drop-in replacement for node's fs module and seems to solve a lot of issues I had with locked files on Windows. I can send a PR if you like.
ryanmcgrath commented 2014-01-16 23:24:51 -08:00 (Migrated from github.com)
Copy link

Interesting, this seems like it would be useful - would be open to a pull request, but at the moment I'm unable to attend to this.

(I'm aware this is 2 months old; lot of things taking up my time at the moment, sadly. Sorry!)

Interesting, this seems like it would be useful - would be open to a pull request, but at the moment I'm unable to attend to this. (I'm aware this is 2 months old; lot of things taking up my time at the moment, sadly. Sorry!)
silverwind commented 2014-01-17 02:40:57 -08:00 (Migrated from github.com)
Copy link

Alright, will send a PR shortly.

Alright, will send a PR shortly.
silverwind commented 2014-01-17 03:22:50 -08:00 (Migrated from github.com)
Copy link

Actually, I'll try the new release first as https://github.com/ryanmcgrath/wrench-js/pull/73 looks promising to fix the Windows issues I'm having.

Actually, I'll try the new release first as https://github.com/ryanmcgrath/wrench-js/pull/73 looks promising to fix the Windows issues I'm having.
ryanmcgrath commented 2014-01-17 18:38:10 -08:00 (Migrated from github.com)
Copy link

Cool! Definitely let me know if it works for you.

Cool! Definitely let me know if it works for you.
silverwind commented 2014-01-22 15:57:46 -08:00 (Migrated from github.com)
Copy link

Nope, I was still hitting an ENOTEMPTY pretty fast when running rmdirSyncRecursive on a mozilla-central source tree (250k files), while graceful-fs deleted it without a hitch.

I'll test some more before submitting the PR, just out of curiosity which part of graceful-fs is actually solving these errors.

Also to note, this module would bump your min version of node to 0.4.0.

Nope, I was still hitting an ENOTEMPTY pretty fast when running rmdirSyncRecursive on a mozilla-central source tree (250k files), while graceful-fs deleted it without a hitch. I'll test some more before submitting the PR, just out of curiosity which part of graceful-fs is actually solving these errors. Also to note, this module would bump your min version of node to 0.4.0.
silverwind commented 2014-02-02 12:36:05 -08:00 (Migrated from github.com)
Copy link

I haven't found time to dissect graceful-fs yet, but I think the issue is corrected somewhere in polyfills.js.

I've submitted the PR now as-is. I don't think the switch would cause any issues, but just to be save, I'd suggest bumping the minor version.

I haven't found time to dissect graceful-fs yet, but I think the issue is corrected somewhere in [polyfills.js](https://github.com/isaacs/node-graceful-fs/blob/master/polyfills.js). I've submitted the PR now as-is. I don't think the switch would cause any issues, but just to be save, I'd suggest bumping the minor version.
This repository is archived. You cannot comment on issues.
No Branch/Tag specified
Branches Tags
master
gh-pages
No results found.
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Request
No labels
Bug
Enhancement
Feature Request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/wrench-js#68
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?