no way to remove directory with contents #71

New issue

Open

opened 2014-01-16 17:33:43 -08:00 by alanning · 1 comment

alanning commented

2014-01-16 17:33:43 -08:00

(Migrated from github.com)

In previous releases (such as 1.3.9) it was possible to delete directories that were not empty.

In 1.5 the default changed but in 1.5.4 there is no way to override and have the deletion complete.

There is a failSilent flag but this comment indicates that at one time there was also a forceDelete override.

/*  wrench.rmdirSyncRecursive("directory_path", forceDelete, failSilent);
 *
 *  Recursively dives through directories and obliterates everything about it. This is a
 *  Sync-function, which blocks things until it's done. No idea why anybody would want an
 *  Asynchronous version. :\
 */
exports.rmdirSyncRecursive = function(path, failSilent) {

forceDelete is a very useful feature and its available for copy so I'm guessing this was an unintended change, possibly due to the recent merge conflicts.

Also, please consider using git tags to track releases so previous versions are more easily viewable.

In previous releases (such as 1.3.9) it was possible to delete directories that were not empty. In 1.5 the default changed but in 1.5.4 there is no way to override and have the deletion complete. There is a failSilent flag but this comment indicates that at one time there was also a forceDelete override. ``` js /* wrench.rmdirSyncRecursive("directory_path", forceDelete, failSilent); * * Recursively dives through directories and obliterates everything about it. This is a * Sync-function, which blocks things until it's done. No idea why anybody would want an * Asynchronous version. :\ */ exports.rmdirSyncRecursive = function(path, failSilent) { ``` forceDelete is a very useful feature and its available for copy so I'm guessing this was an unintended change, possibly due to the recent merge conflicts. Also, please consider using git tags to track releases so previous versions are more easily viewable.

ryanmcgrath commented

2014-01-16 23:16:39 -08:00

(Migrated from github.com)

You're correct, this should be available. I'm unable to directly handle this at the moment, but anyone who submits pull requests I'm happy to pipeline up provided there's a test accompanying it.

This repository is archived. You cannot comment on issues.

No labels

Bug

Enhancement

Feature Request

No milestone

No project

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/wrench-js#71

No description provided.

Rows
Columns