From 2abdfaf40c2d7ece8184ac6d2e10573995c2d4a6 Mon Sep 17 00:00:00 2001 From: domenic Date: Mon, 14 May 2012 19:14:16 -0400 Subject: [PATCH 1/3] Add npm-debug.log to .gitignore. --- .gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index b512c09..93f1361 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,2 @@ -node_modules \ No newline at end of file +node_modules +npm-debug.log -- 2.39.5 From 99342e073f1a7231adc3f21cc8af7f3dd1686125 Mon Sep 17 00:00:00 2001 From: domenic Date: Mon, 14 May 2012 19:15:28 -0400 Subject: [PATCH 2/3] Updating test script to work on Windows. npm had a bug a while ago where you needed to specify the full path for scripts. This is no longer the case. Using the command name instead of the full path allows `npm test` to work on Windows. --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 1e7eb15..424e6ea 100644 --- a/package.json +++ b/package.json @@ -31,7 +31,7 @@ "node": ">=0.1.97" }, - "scripts": { "test": "./node_modules/nodeunit/bin/nodeunit tests/runner.js" }, + "scripts": { "test": "nodeunit tests/runner.js" }, "licenses": [{ "type" : "MIT", -- 2.39.5 From 828798c43c40725853db7c310beaf06fa6930e85 Mon Sep 17 00:00:00 2001 From: domenic Date: Mon, 14 May 2012 19:21:37 -0400 Subject: [PATCH 3/3] Using nodeunit's deepEqual instead of manually looping. This makes for more readable assertion messages (so you can actually see the difference in the lists), and removes the underscore dependency. --- package.json | 3 +-- tests/readdir.js | 7 +------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/package.json b/package.json index 424e6ea..4cc9362 100644 --- a/package.json +++ b/package.json @@ -21,8 +21,7 @@ }, "devDependencies": { - "nodeunit": ">= 0.6.4", - "underscore": ">= 1.3.1" + "nodeunit": ">= 0.6.4" }, "main": "./lib/wrench", diff --git a/tests/readdir.js b/tests/readdir.js index b2d14f0..bca8ad6 100644 --- a/tests/readdir.js +++ b/tests/readdir.js @@ -2,7 +2,6 @@ var testCase = require('nodeunit').testCase; var fs = require('fs'); var wrench = require('../lib/wrench'); var path = require('path'); -var _und = require("underscore"); function checkResult(test, files) { @@ -15,11 +14,7 @@ function checkResult(test, files) { 'foo/bar/ipsum.js' ]; - test.equals(files.length, check.length, 'number of paths is correct'); - - _und.each(check, function(it) { - test.ok(_und.include(files, it), 'path ' + it + ' should be returned'); - }); + test.deepEqual(files, check); test.done(); } -- 2.39.5