#17: Python3 and Django 3.1 migration #18

Open

brezerk wants to merge 2 commits from brezerk/django3.1 into master

pull from: brezerk/django3.1

merge into: code:master

code:master

Conversation 1 Commits 2 Files changed 2 +4 -4

brezerk commented 2020-09-06 02:34:43 -07:00 (Migrated from github.com)

Copy link

Hi

Seems like there is on_delete field missing in twython_django_oauth/models.py:

  File "/home/brezerk/develop/example/.venv/lib/python3.6/site-packages/twython_django_oauth/models.py", line 5, in <module>
    class TwitterProfile(models.Model):
  File "/home/brezerk/develop/example/.venv/lib/python3.6/site-packages/twython_django_oauth/models.py", line 11, in TwitterProfile
    user = models.OneToOneField(User)
TypeError: __init__() missing 1 required positional argument: 'on_delete'

https://docs.djangoproject.com/en/3.1/ref/models/fields/#django.db.models.ForeignKey.on_delete

Addresses: https://github.com/ryanmcgrath/twython-django/issues/17

Hi Seems like there is on_delete field missing in twython_django_oauth/models.py: ``` File "/home/brezerk/develop/example/.venv/lib/python3.6/site-packages/twython_django_oauth/models.py", line 5, in <module> class TwitterProfile(models.Model): File "/home/brezerk/develop/example/.venv/lib/python3.6/site-packages/twython_django_oauth/models.py", line 11, in TwitterProfile user = models.OneToOneField(User) TypeError: __init__() missing 1 required positional argument: 'on_delete' ``` https://docs.djangoproject.com/en/3.1/ref/models/fields/#django.db.models.ForeignKey.on_delete Addresses: https://github.com/ryanmcgrath/twython-django/issues/17

brezerk commented 2020-09-06 08:38:00 -07:00 (Migrated from github.com)

Copy link

More fixes:

Django 3.1 migration

• Fixed: ImportError: Django ImportError: cannot import name 'render_to_response' from 'django.shortcuts'
• Fixed: ImportError: No module named 'django.core.urlresolvers'

More fixes: Django 3.1 migration * Fixed: ImportError: Django ImportError: cannot import name 'render_to_response' from 'django.shortcuts' * Fixed: ImportError: No module named 'django.core.urlresolvers'

This repository is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython-django#18

No description provided.