code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Added support for the new direct message endpoints #500

Merged
manuelcortez merged 5 commits from master into master 2019-04-10 07:01:10 -07:00
Conversation 11 Commits 5 Files changed 2 +29 -17
manuelcortez commented 2018-09-29 09:23:03 -07:00 (Migrated from github.com)
Copy link

This adds support for the new event based direct messages methods, available after August 16. In particular, get_direct_messages, get_direct_message, send_direct_message and destroy_direct_message were changed to the new methods provided in Twitter. Take into account that new objects (events) are returned for all GET methods related to direct messages, and in order to send a direct message you have to send an event in a dictionary as specified in the Documentation of this method. Also, the function get_send_messages should be removed, as is no longer possible to use that endpoint.

This adds support for the new event based direct messages methods, available after August 16. In particular, get_direct_messages, get_direct_message, send_direct_message and destroy_direct_message were changed to the new methods provided in Twitter. Take into account that new objects (events) are returned for all GET methods related to direct messages, and in order to send a direct message you have to send an event in a dictionary as specified in the [Documentation of this method.](https://developer.twitter.com/en/docs/direct-messages/sending-and-receiving/api-reference/new-event.html) Also, the function get_send_messages should be removed, as is no longer possible to use that endpoint.
👀 1 🎉 3
coveralls commented 2018-09-29 09:24:39 -07:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage increased (+0.02%) to 57.467% when pulling 4f29fd041b on manuelcortez:master into c9e8a46200 on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/20142878/badge)](https://coveralls.io/builds/20142878) Coverage increased (+0.02%) to 57.467% when pulling **4f29fd041b960569e46cdf17e08455d40cfc7f66 on manuelcortez:master** into **c9e8a462000898dcd91b9babf130b907986591ea on ryanmcgrath:master**.
Menelion commented 2018-09-29 13:58:31 -07:00 (Migrated from github.com)
Copy link

@michaelhelmick Could you look at this please? I'm pretty sure it can be merged (and it needs to!). The library is behind Twitter's state of things, unfortunately. Thanks!

@michaelhelmick Could you look at this please? I'm pretty sure it can be merged (and it needs to!). The library is behind Twitter's state of things, unfortunately. Thanks!
anapaulagomes (Migrated from github.com) reviewed 2018-09-30 07:07:08 -07:00
twython/api.py
@ -135,13 +135,13 @@ class Twython(EndpointsMixin, object):
def __repr__(self):
anapaulagomes (Migrated from github.com) commented 2018-09-30 07:07:08 -07:00
Copy link

I think json_encoded is False would be better.

I think `json_encoded is False` would be better.
anapaulagomes (Migrated from github.com) reviewed 2018-09-30 07:09:40 -07:00
twython/api.py
@ -153,11 +153,16 @@ class Twython(EndpointsMixin, object):
if k in ('timeout', 'allow_redirects', 'stream', 'verify'):
anapaulagomes (Migrated from github.com) commented 2018-09-30 07:09:40 -07:00
Copy link

Seems single quotes are part of the project code style. 🤔

Seems single quotes are part of the project code style. :thinking:
Menelion commented 2018-11-13 03:48:51 -08:00 (Migrated from github.com)
Copy link

@ryanmcgrath @michaelhelmick Any insights on this? Could you please merge this in?

@ryanmcgrath @michaelhelmick Any insights on this? Could you please merge this in?
ryanmcgrath commented 2018-11-13 09:42:59 -08:00 (Migrated from github.com)
Copy link

Offhand it looks okay to me, but in case anyone's not noticed, Mike clearly pays more attention than I do these days. :(

Side note: I believe there was a call for maintainers put out a few months ago, or at least for extra helping hands re: committing/merging... did that fall through the cracks?

Offhand it looks okay to me, but in case anyone's not noticed, Mike clearly pays more attention than I do these days. :( Side note: I believe there was a call for maintainers put out a few months ago, or at least for extra helping hands re: committing/merging... did that fall through the cracks?
👍 1
Menelion commented 2018-11-13 10:05:02 -08:00 (Migrated from github.com)
Copy link

Thanks @ryanmcgrath! The PR was submitted in September, so I'm pinging as I'm also interested in this particular change :).

Thanks @ryanmcgrath! The PR was submitted in September, so I'm pinging as I'm also interested in this particular change :).
manuelcortez commented 2018-11-13 10:30:38 -08:00 (Migrated from github.com)
Copy link

@ryanmcgrath I didn't know you were looking for contributors. I would be up for helping in what is needed, instead of keeping my own fork up to date with Twitter's last changes. Let me know if you need me to send changes to the pr.

@ryanmcgrath I didn't know you were looking for contributors. I would be up for helping in what is needed, instead of keeping my own fork up to date with Twitter's last changes. Let me know if you need me to send changes to the pr.
michaelhelmick commented 2018-11-15 11:20:56 -08:00 (Migrated from github.com)
Copy link

Hi all!

Sorry, this must have missed my inbox.

@ryanmcgrath Not sure if the call for contributors fell through, but I'll try and put one out after the Thanksgiving holiday (with @manuelcortez being a lead candidate :))!

The only issue I see with this is that data_key is spaced in a bit far under the first if, fix that and I'll merge this.

Hi all! Sorry, this must have missed my inbox. @ryanmcgrath Not sure if the call for contributors fell through, but I'll try and put one out after the Thanksgiving holiday (with @manuelcortez being a lead candidate :))! The only issue I see with this is that `data_key` is spaced in a bit far under the first `if`, fix that and I'll merge this.
👍 1 🎉 1
Menelion commented 2018-11-15 12:05:47 -08:00 (Migrated from github.com)
Copy link

Please count my vote for @manuelcortez :). He develops an influential Twitter client for blind and visually impaired. I also develop such a client, but my audience is smaller, and my code is in a far messier state, unfortunately.

Please count my vote for @manuelcortez :). He develops an influential Twitter client for blind and visually impaired. I also develop such a client, but my audience is smaller, and my code is in a far messier state, unfortunately.
lukaszgo1 commented 2019-02-10 13:36:04 -08:00 (Migrated from github.com)
Copy link

@ryanmcgrath @michaelhelmick What is the status of This? Can it be merged?

@ryanmcgrath @michaelhelmick What is the status of This? Can it be merged?
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#500
No description provided.
Delete branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?