code/twython
1
Fork 0
Code Issues 23 Pull requests 4 Projects Releases 5 Packages Wiki Activity Actions

Fix #522 (needed bc of PEP 479) #540

Merged
fogti merged 2 commits from fix4pep479 into master 2021-07-16 13:10:28 -07:00
Conversation 8 Commits 2 Files changed 1 +4 -3
fogti commented 2021-01-26 13:24:30 -08:00 (Migrated from github.com)
Copy link

Fixes #522.

Fixes #522.
coveralls commented 2021-01-26 15:52:10 -08:00 (Migrated from github.com)
Copy link

Coverage Status

Coverage increased (+0.06%) to 57.201% when pulling 61c1ba9600 on zserik:fix4pep479 into 8e004f5d89 on ryanmcgrath:master.

[![Coverage Status](https://coveralls.io/builds/36617663/badge)](https://coveralls.io/builds/36617663) Coverage increased (+0.06%) to 57.201% when pulling **61c1ba9600986d8263af81b8cee954828bb7ce7c on zserik:fix4pep479** into **8e004f5d8948cbddefba98ad971bfde2555ec3be on ryanmcgrath:master**.
fogti (Migrated from github.com) reviewed 2021-01-31 13:37:41 -08:00
twython/api.py
@ -9,6 +9,7 @@ Twitter Authentication, and miscellaneous methods that are useful when
dealing with the Twitter API
"""
from __future__ import generator_stop
fogti (Migrated from github.com) commented 2021-01-31 13:37:41 -08:00
Copy link

I'm unsure if this import is actually needed.

I'm unsure if this `import` is actually needed.
fogti commented 2021-07-16 03:00:56 -07:00 (Migrated from github.com)
Copy link

@RaitoBezarius could you please review this PR?

@ryanmcgrath could you please merge this PR? (refs: https://github.com/ryanmcgrath/twython/issues/522#issuecomment-582153066, https://github.com/ryanmcgrath/twython/issues/522#issuecomment-554648143)

@RaitoBezarius could you please review this PR? @ryanmcgrath could you please merge this PR? (refs: https://github.com/ryanmcgrath/twython/issues/522#issuecomment-582153066, https://github.com/ryanmcgrath/twython/issues/522#issuecomment-554648143)
ryanmcgrath commented 2021-07-16 11:05:51 -07:00 (Migrated from github.com)
Copy link

Ah, I can merge this if one or two people test it and say it's good to go. I assume this'd also need a release bump?

Ah, I can merge this if one or two people test it and say it's good to go. I assume this'd also need a release bump?
fogti commented 2021-07-16 11:20:44 -07:00 (Migrated from github.com)
Copy link

I'm not completely sure anymore, but I thought I had tested it.

I'm not completely sure anymore, but I thought I had tested it.
ryanmcgrath commented 2021-07-16 11:23:16 -07:00 (Migrated from github.com)
Copy link

Oh, I believe you tested it - it's more that I don't touch this part of the library these days, so want to be sure that:

A) it's got a decent pair of eyes on it (though given issue 522 I suppose we could just yolo it, since the discussion there has been around for some time)

B) we do a version bump so we're not blowing up too many existing setups etc

Let's ping @RaitoBezarius one more time, and then if they're too busy to take a peek (given it's also been some time) we'll go the yolo approach.

Oh, I believe you tested it - it's more that I don't touch this part of the library these days, so want to be sure that: A) it's got a decent pair of eyes on it (though given issue 522 I suppose we could just yolo it, since the discussion there has been around for some time) B) we do a version bump so we're not blowing up too many existing setups etc Let's ping @RaitoBezarius one more time, and then if they're too busy to take a peek (given it's also been some time) we'll go the yolo approach.
RaitoBezarius commented 2021-07-16 12:53:06 -07:00 (Migrated from github.com)
Copy link

To be honest, I didn't test it yet, but it looks good, I think the yolo plan is not that much absurd.
I think the __future__ import makes sense for older Python 3 versions, but should work more or less fine on latest ones IMHO.

So all good for me @ryanmcgrath !

To be honest, I didn't test it yet, but it looks good, I think the yolo plan is not that much absurd. I think the `__future__` import makes sense for older Python 3 versions, but should work more or less fine on latest ones IMHO. So all good for me @ryanmcgrath !
👍 1
ryanmcgrath commented 2021-07-16 14:38:34 -07:00 (Migrated from github.com)
Copy link

Alright, a 3.9.0 should be on Pypi now.

Alright, a `3.9.0` should be on Pypi now.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Suggestion
No labels
Bug
Enhancement
Feature Suggestion
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#540
No description provided.
Delete branch "fix4pep479"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?