code/wrench-js
Archived
1
Fork 0
Code Issues 22 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Update wrench.js #59

Merged
aogriffiths merged 1 commit from patch-1 into master 2013-10-15 14:51:41 -07:00
Conversation 1 Commits 1 Files changed 1 +2 -1
aogriffiths commented 2013-08-04 11:18:23 -07:00 (Migrated from github.com)
Copy link

Fixes a bug (not sure if has been reported).

copyDirRecursive calls itself from the rmdirRecursive callback when newDir exists. It should call itself with the original copyDirRecursive arguments, not the callback arguments.

Also fun.apply(thisArg, argsArray) expects argsArray to be an array (see here) but arguments is not an array (see here)

Very similar to pull request 56 (I wrote my code before I noticed danielholmes did a similar fix).

Fixes a bug (not sure if has been reported). `copyDirRecursive` calls itself from the `rmdirRecursive` callback when newDir exists. It should call itself with the original copyDirRecursive arguments, not the callback arguments. Also `fun.apply(thisArg, argsArray)` expects argsArray to be an array (see [here](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply)) but `arguments` is not an array (see [here](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions_and_function_scope/arguments)) Very similar to [pull request 56](https://github.com/ryanmcgrath/wrench-js/pull/56) (I wrote my code before I noticed danielholmes did a similar fix).
ryanmcgrath commented 2013-10-15 14:52:01 -07:00 (Migrated from github.com)
Copy link

Heeeey so yeah this looks fine let's merge this sure.

Only ~2 months late on my part. You rock.

Heeeey so yeah this looks fine let's merge this sure. Only ~2 months late on my part. You rock.
This repository is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Request
No labels
Bug
Enhancement
Feature Request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/wrench-js#59
No description provided.
Delete branch "patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?