code/wrench-js
Archived
1
Fork 0
Code Issues 22 Pull requests 7 Projects Releases Packages Wiki Activity Actions

Fix inflateSymlinks flag errors for absolute symlinks #79

Merged
xzyfer merged 1 commit from fix/sync-absolute-symlink into master 2014-02-09 22:18:19 -08:00
Conversation 1 Commits 1 Files changed 2 +40 -3
xzyfer commented 2014-02-09 22:06:42 -08:00 (Migrated from github.com)
Copy link

The inflateSymlinks: true for copyDirSyncRecursive assumes symlinks will have relatives paths. A symlink with an absolute path throws an error since the path cannot be correctly resolved.

This pull request fixes those errors and adds tests.

The `inflateSymlinks: true` for `copyDirSyncRecursive` assumes symlinks will have relatives paths. A symlink with an absolute path throws an error since the path cannot be correctly resolved. This pull request fixes those errors and adds tests.
ryanmcgrath commented 2014-02-09 22:18:32 -08:00 (Migrated from github.com)
Copy link

Seems good, merged. Thanks for the catch/pull request!

Seems good, merged. Thanks for the catch/pull request!
This repository is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels   
Bug

   
Enhancement

   
Feature Request
No labels
Bug
Enhancement
Feature Request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/wrench-js#79
No description provided.
Delete branch "fix/sync-absolute-symlink"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?