Cursor fix #386

Merged
eoso merged 2 commits from cursor-fix into master 2018-05-07 08:35:26 -07:00
eoso commented 2015-08-06 16:14:34 -07:00 (Migrated from github.com)

I fixed the cursor function to grab next pages of results when using the search function or one of the timeline functions. (Copy of previous pull request in which I had made a mistake with git branches.)

I fixed the cursor function to grab next pages of results when using the search function or one of the timeline functions. (Copy of previous pull request in which I had made a mistake with git branches.)
michaelhelmick commented 2015-08-13 08:21:35 -07:00 (Migrated from github.com)

Was there an issue out for this PR?

Was there an issue out for this PR?
michaelhelmick commented 2015-09-12 04:44:58 -07:00 (Migrated from github.com)
Hi @eoso. Just re-uping https://github.com/ryanmcgrath/twython/pull/386#issuecomment-130727647
eoso commented 2015-09-12 18:45:47 -07:00 (Migrated from github.com)

Hey, thanks for getting my attention. I got busy.

I noticed that when iterator mode uses since_ids, the cursor generator would start repeatedly yielding the same tweet once it reached the end of it's initial block of tweets.

A few people had similar problems: #365, #325.

I noticed that someone had written a fix (which also included a sleep function) over a year ago but wasn't pulled: #332

I can post some code later as well, if that's helpful, but don't have the time to get it setup at the moment.

Hey, thanks for getting my attention. I got busy. I noticed that when iterator mode uses since_ids, the cursor generator would start repeatedly yielding the same tweet once it reached the end of it's initial block of tweets. A few people had similar problems: #365, #325. I noticed that someone had written a fix (which also included a sleep function) over a year ago but wasn't pulled: #332 I can post some code later as well, if that's helpful, but don't have the time to get it setup at the moment.
ababino commented 2016-07-07 14:17:12 -07:00 (Migrated from github.com)

Dear all,
I had a problem with cursor and get_user_timeline but the fix by @eoso solved it! Please, if it is possible, mearge the fix. If there is anything I can help with please let me know.
Bests

Dear all, I had a problem with cursor and get_user_timeline but the fix by @eoso solved it! Please, if it is possible, mearge the fix. If there is anything I can help with please let me know. Bests
AmauryCarrade commented 2016-10-20 15:26:55 -07:00 (Migrated from github.com)

Same here, this PR fixed the cursors bug with get_user_timeline for me.

Same here, this PR fixed the cursors bug with `get_user_timeline` for me.
dannguyen commented 2017-01-02 11:16:08 -08:00 (Migrated from github.com)

I was writing a tutorial on how to use Twython for collecting tweets, particularly, paginating through a user's available timeline and was wondering if there was an estimated ETA for merging in this pull request into a new release?

I was writing a tutorial on how to use Twython for collecting tweets, particularly, paginating through a user's available timeline and was wondering if there was an estimated ETA for merging in this pull request into a new release?
michaelhelmick commented 2017-09-25 07:22:05 -07:00 (Migrated from github.com)

Re-pinging @eoso?

Re-pinging @eoso?
decklord commented 2018-05-04 14:44:36 -07:00 (Migrated from github.com)

Can you merge this?

Can you merge this?
michaelhelmick commented 2018-05-07 08:35:22 -07:00 (Migrated from github.com)

By popular demand, I will merge this despite tests. I'll try and do a release soon.

By popular demand, I will merge this despite tests. I'll try and do a release soon.
michaelhelmick commented 2018-05-07 09:54:11 -07:00 (Migrated from github.com)

Twython 3.7.0 is now available on PyPI

Twython 3.7.0 is now available on PyPI
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: code/twython#386
No description provided.